chore(protractor): support Protractor 5.x.x with the new webdriver-manager #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JK. I looked at Protractor master branch.... I think I can fake in something to work. Maybe JS files in the lib/ that get copied to built/lib/config. This is not ready for prime time yet. |
cnishina
changed the title
cnishina
force-pushed
the
support_legacy
branch
from
3223a6e to
5800b2d
Compare
cnishina
changed the title
cnishina
force-pushed
the
support_legacy
branch
from
5800b2d to
ba7b77f
Compare
|
Okay this should be ready for review now. It creates the update-config.json file from the existing config files. The directories match: Note this always rewrites the file on every static call. I could check to see the age of the file but the max rewrite is 3 times. This isn't the best fix and will make it better if there is a problem. |
heathkit
suggested changes
Apr 26, 2019
cnishina
changed the title
heathkit
approved these changes
Jun 5, 2019
…nager - During the static call (for 5.4.2 to built/lib/config) to getSeleniumDir, construct the update-config.json. This is just combining existing information from geckodriver.config.json, chrome.config.json and selenium-server.config.json. Important note that since this is just added in, this file will not be removed during the clean up and will always be overwritten when making the static call. If it is called 3 times in the driverProviders/local test, it will rewrite the file 3 times. - Add test for Protractor. For both version 5.4.2 and version 6+ calls to webdriver-manager. - Add jasmine protractor test to circle ci test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSeleniumDir, construct the update-config.json. This is just combining
existing information from geckodriver.config.json, chrome.config.json
and selenium-server.config.json. Important note that since this is just
added in, this file will not be removed during the clean up and will
always be overwritten when making the static call. If it is called 3
times in the driverProviders/local test, it will rewrite the file 3
times.
to webdriver-manager.