This repository was archived by the owner on Jan 6, 2025. It is now read-only.
fix(fxLayoutGap): account for responsive fxHide on children elements #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return this.styler.lookupStyle(source, query); | ||
| /** Determine if an element will show or hide based on current activation */ | ||
| protected willDisplay(source: HTMLElement): boolean { | ||
| const value = this.marshal.getValue(source, 'show-hide'); |
There was a problem hiding this comment.
How about this for better clarity:
const value = this.marshal.getValue(source, 'show-hide');
if ( value == '' || value == undefined) {
// Current value is not explicitly set (to 'false' or 'true'), so lookStyle()
value = this.styleUtils.lookupStyle(source, 'display') !== 'none';
}
return value;There was a problem hiding this comment.
I don't think the value gain is great in terms of clarity: the value returned from the marshaller will never be undefined.
|
Blocked because this doesn't entirely fix the issue. Will investigate further today. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #606