This repository was archived by the owner on Jan 6, 2025. It is now read-only.
build: update rxjs operators and jasmine #523
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaerusKaru
force-pushed
the
deps
branch
4 times, most recently
from
a8dd84e to
125a4b8
Compare
|
Passes all tests. |
|
It would be great if you could update this PR for Angular 5.1 and cdk 5.0.0 (stable) which were released tonight. |
|
@fbascheper Added |
CaerusKaru
changed the title
* fix: import individual rx operators * Removes 'rxjs/operators' import in favor of indivial imports, adds lint rule to prevent that type of import * Maintains parity with angular/components#8160
|
Merged with SHA 62457a5.
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates PR #474 and updates rxjs to latest best practices
Fixes #519, #508, #533