fix(material/sidenav): fix tabindex issue on side mode #30979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove tabindex=-1 from mat-drawer when in mode="side" so mobile screen readers like TalkBack does not focus on the container fixes b/286459024
andrewseguin
added
the
dev-app preview
|
Deployed dev-app for a1c6329 to: https://ng-dev-previews-comp--pr-angular-components-30979-dev-a2aqsdxi.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
DBowen33
requested review from
adolgachev and
crisbeto
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove tabindex=-1 from mat-drawer when in mode="side" so that the mat-drawer container it is not focusable by mobile screen readers such as TalkBack
Before Screencast: https://screencast.googleplex.com/cast/NTYzNjAxNjE0Nzc5MTg3MnwzOGVlNmNmZC1jYQ
After Screencast: https://screencast.googleplex.com/cast/NDg5NzA2MTg1NzEzMjU0NHxjZTcyZGY5MS04OA
fixes b/286459024