fix(cdk-experimental/listbox): change shift+nav behavior #30854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagnermaciel
added
the
dev-app preview
|
Deployed dev-app for 6f8ce0e to: https://ng-dev-previews-comp--pr-angular-components-30854-dev-7gsw2eis.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
wagnermaciel
force-pushed
the
listbox-range-selection
branch
from
f4b437f to
a40bb1a
Compare
wagnermaciel
requested review from
crisbeto and
mmalerba
and removed request for
a team
mmalerba
approved these changes
Apr 14, 2025
|
@mmalerba I think I've come up with a cleaner solution for this. I'm going to try and take another stab at this tomorrow and I'll send for re-review. Sorry for the double-review on this one |
wagnermaciel
force-pushed
the
listbox-range-selection
branch
from
5703018 to
0c6b0f5
Compare
|
@mmalerba Ok, finally got this into a ready state. Fixing the shift+nav behavior ended up being a can of worms. Let me know if you think this PR has ballooned up too big to review and I'll split it up into smaller chunks. |
mmalerba
approved these changes
Apr 16, 2025
src/cdk-experimental/ui-patterns/behaviors/list-selection/list-selection.spec.ts
Show resolved
Hide resolved
wagnermaciel
force-pushed
the
listbox-range-selection
branch
from
905f27f to
004076c
Compare
mmalerba
approved these changes
Apr 17, 2025
wagnermaciel
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.