build: fix rules_sass error #24331
Merged
build: fix rules_sass error #24331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
rules-sass-error
branch
from
f7aa1b1 to
1ac0565
Compare
crisbeto
added
merge safe
P2
devversion
approved these changes
Feb 1, 2022
Updates to the latest version of `rules_sass` in order to fix an error that is currently breaking the build.
crisbeto
force-pushed
the
rules-sass-error
branch
from
1ac0565 to
d134482
Compare
crisbeto
added a commit
that referenced
this pull request
Feb 1, 2022
Updates to the latest version of `rules_sass` in order to fix an error that is currently breaking the build. (cherry picked from commit f201634)
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Feb 1, 2022
Similar to angular/components#24331. Updates to the latest version of `rules_sass` in order to fix an error that is currently breaking the build.
PooSham
added a commit
to PooSham/Angular-Material-Components
that referenced
this pull request
Feb 2, 2022
commit 261cb7c Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Tue Feb 1 21:26:03 2022 +0100 fix(material/dialog): Fix mdc action align test commit b060272 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Tue Feb 1 21:10:12 2022 +0100 fix(material/dialog): update golden api for dialog commit 69491e1 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Tue Feb 1 17:50:37 2022 +0100 fix(material/dialog): fix mismatching test names between mdc and non-mdc commit b4a9cb3 Author: Paul Gschwendtner <paulgschwendtner@gmail.com> Date: Tue Feb 1 17:09:37 2022 +0100 fixup! fix(material/dialog): Use align as @input() in MatDialogActions ds commit d7a9cbb Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 31 19:27:13 2022 +0100 fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 815cf8f Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <jeanphilippe.green@gmail.com> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <jeanphilippe.green@gmail.com> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 commit a74d92e Author: Kristiyan Kostadinov <crisbeto@users.noreply.github.com> Date: Tue Feb 1 16:43:35 2022 +0100 fix(material/menu): adjust overlay size when amount of items changes (angular#21457) Currently we lock the menu into a position after it is opened so that it doesn't jump around when the user scrolls, but this means that if the amount of items changes, it might not be the optimal position anymore. These changes add some code to re-calculate the position if the amount of items changes. Fixes angular#21456. commit f201634 Author: Kristiyan Kostadinov <crisbeto@users.noreply.github.com> Date: Tue Feb 1 13:22:16 2022 +0100 build: fix rules_sass error (angular#24331) Updates to the latest version of `rules_sass` in order to fix an error that is currently breaking the build.
wagnermaciel
pushed a commit
that referenced
this pull request
Feb 11, 2022
…#24328) * fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479-2 commit 815cf8f Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <jeanphilippe.green@gmail.com> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes #18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <jeanphilippe.green@gmail.com> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes #18479 * fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479-2 commit 815cf8f Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <jeanphilippe.green@gmail.com> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes #18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <jeanphilippe.green@gmail.com> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes #18479 * fixup! fix(material/dialog): Use align as @input() in MatDialogActions ds * fix(material/dialog): fix mismatching test names between mdc and non-mdc * fix(material/dialog): fix mismatching test names between mdc and non-mdc * fix(material/dialog): update golden api for dialog * fix(material/dialog): Fix mdc action align test * fix(material/dialog): update golden api for dialog * fix(material/dialog): Fix mdc action align test * fix(material/dialog): Squashed commit of the following: commit 261cb7c Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Tue Feb 1 21:26:03 2022 +0100 fix(material/dialog): Fix mdc action align test commit b060272 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Tue Feb 1 21:10:12 2022 +0100 fix(material/dialog): update golden api for dialog commit 69491e1 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Tue Feb 1 17:50:37 2022 +0100 fix(material/dialog): fix mismatching test names between mdc and non-mdc commit b4a9cb3 Author: Paul Gschwendtner <paulgschwendtner@gmail.com> Date: Tue Feb 1 17:09:37 2022 +0100 fixup! fix(material/dialog): Use align as @input() in MatDialogActions ds commit d7a9cbb Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 31 19:27:13 2022 +0100 fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479-2 commit 815cf8f Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <jeanphilippe.green@gmail.com> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes #18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <jeanphilippe.green@gmail.com> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes #18479 commit a74d92e Author: Kristiyan Kostadinov <crisbeto@users.noreply.github.com> Date: Tue Feb 1 16:43:35 2022 +0100 fix(material/menu): adjust overlay size when amount of items changes (#21457) Currently we lock the menu into a position after it is opened so that it doesn't jump around when the user scrolls, but this means that if the amount of items changes, it might not be the optimal position anymore. These changes add some code to re-calculate the position if the amount of items changes. Fixes #21456. commit f201634 Author: Kristiyan Kostadinov <crisbeto@users.noreply.github.com> Date: Tue Feb 1 13:22:16 2022 +0100 build: fix rules_sass error (#24331) Updates to the latest version of `rules_sass` in order to fix an error that is currently breaking the build. Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>
amysorto
pushed a commit
to amysorto/components
that referenced
this pull request
Feb 15, 2022
Updates to the latest version of `rules_sass` in order to fix an error that is currently breaking the build.
amysorto
pushed a commit
to amysorto/components
that referenced
this pull request
Feb 15, 2022
…angular#24328) * fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 815cf8f Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <jeanphilippe.green@gmail.com> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <jeanphilippe.green@gmail.com> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 * fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 815cf8f Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <jeanphilippe.green@gmail.com> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <jeanphilippe.green@gmail.com> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 * fixup! fix(material/dialog): Use align as @input() in MatDialogActions ds * fix(material/dialog): fix mismatching test names between mdc and non-mdc * fix(material/dialog): fix mismatching test names between mdc and non-mdc * fix(material/dialog): update golden api for dialog * fix(material/dialog): Fix mdc action align test * fix(material/dialog): update golden api for dialog * fix(material/dialog): Fix mdc action align test * fix(material/dialog): Squashed commit of the following: commit 261cb7c Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Tue Feb 1 21:26:03 2022 +0100 fix(material/dialog): Fix mdc action align test commit b060272 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Tue Feb 1 21:10:12 2022 +0100 fix(material/dialog): update golden api for dialog commit 69491e1 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Tue Feb 1 17:50:37 2022 +0100 fix(material/dialog): fix mismatching test names between mdc and non-mdc commit b4a9cb3 Author: Paul Gschwendtner <paulgschwendtner@gmail.com> Date: Tue Feb 1 17:09:37 2022 +0100 fixup! fix(material/dialog): Use align as @input() in MatDialogActions ds commit d7a9cbb Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 31 19:27:13 2022 +0100 fix(material/dialog): Use align as @input() in MatDialogActions Squashed commit of the following: commit 1d6daeadf8e06e38c64fec724d5a8d2899b502d3 Merge: 3276432 3a98da8 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 31 19:24:24 2022 +0100 Merge branch 'master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 3276432 Merge: 815cf8f 1f40b7d Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Mon Jan 31 18:54:42 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479-2 commit 815cf8f Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 01:23:12 2022 +0100 Use directive binding in mdc-dialog demo for align commit 77fca70 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 01:20:43 2022 +0100 Change actionsAlignment type in dialog demo commit c87c4aa Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Mon Jan 10 00:21:57 2022 +0100 Revert weird changes to dialog.spec.ts commit d6deb45 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 23:30:24 2022 +0100 Use 'start' as default instead of undefined for align attribute in dialog actions commit 8d367c1 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 23:05:54 2022 +0100 Update comments in dialog.scss for more clarity commit 9d2ac16 Merge: 54d0a60 3de4ab8 Author: Jean-Philippe <jeanphilippe.green@gmail.com> Date: Sun Jan 9 22:33:13 2022 +0100 Merge branch 'angular:master' into align-attr-as-input-in-dialog-actions-angular#18479 commit 54d0a60 Merge: 462d407 c79e1d1 Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Wed Jan 5 21:30:29 2022 +0100 Merge branch 'angular-master' into align-attr-as-input-in-dialog-actions-angular#18479 commit c79e1d1 Merge: 462d407 03485cd Author: Jean-Philippe Green <jeanphilippe.green@protonmail.com> Date: Wed Jan 5 21:23:17 2022 +0100 Merge branch 'master' of https://github.com/angular/components into angular-master commit 462d407 Author: Jean-Philippe Green <jeanphilippe.green@gmail.com> Date: Fri Dec 25 16:18:08 2020 +0100 fix(material-experimental/mdc-dialog): make align attr into an input of dialog actions directive Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 for material-experimental commit c101f7f Author: Jean-Philippe Green <jeanphilippe.green@gmail.com> Date: Fri Dec 25 16:15:01 2020 +0100 fix(material/dialog): make align attribute into an input of dialog actions directive instead of css Fixes multiple issues, such as self-documentation of the align attribute, type checking, better bindings, and IDE support. Because align is not standard for HTMLDivElement, it doesn't make much sense to assume end users to know they can use the align attribute. Fixes angular#18479 commit a74d92e Author: Kristiyan Kostadinov <crisbeto@users.noreply.github.com> Date: Tue Feb 1 16:43:35 2022 +0100 fix(material/menu): adjust overlay size when amount of items changes (angular#21457) Currently we lock the menu into a position after it is opened so that it doesn't jump around when the user scrolls, but this means that if the amount of items changes, it might not be the optimal position anymore. These changes add some code to re-calculate the position if the amount of items changes. Fixes angular#21456. commit f201634 Author: Kristiyan Kostadinov <crisbeto@users.noreply.github.com> Date: Tue Feb 1 13:22:16 2022 +0100 build: fix rules_sass error (angular#24331) Updates to the latest version of `rules_sass` in order to fix an error that is currently breaking the build. Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the latest version of
rules_sassin order to fix an error that is currently breaking the build.