feat(material/icon): add support for registry resolver function #21431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
Currently all of the ways to register icons (e.g. via URL or literal) require the developer to know the list of icons ahead of time or to fetch more icons than the user needs. These changes aim to address this issue by adding the ability to register an icon resolver function which will construct the URL at runtime, depending on the requested icon. Fixes angular#18607.
crisbeto
force-pushed
the
18607/icon-registry-resolver
branch
from
6b499b3 to
ce30716
Compare
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…lar#21431) Currently all of the ways to register icons (e.g. via URL or literal) require the developer to know the list of icons ahead of time or to fetch more icons than the user needs. These changes aim to address this issue by adding the ability to register an icon resolver function which will construct the URL at runtime, depending on the requested icon. Fixes angular#18607.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all of the ways to register icons (e.g. via URL or literal) require the developer to know the list of icons ahead of time or to fetch more icons than the user needs. These changes aim to address this issue by adding the ability to register an icon resolver function which will construct the URL at runtime, depending on the requested icon.
Fixes #18607.