Skip to content

Fixed drag&drop inside dialog #18670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed drag&drop inside dialog #18670

wants to merge 1 commit into from

Conversation

maksymmakartsov
Copy link

fix(cdk/drag-drop): drag&drop not working inside dialog if the page was scrolled

Fixes a bug in Angular Material 'drag-drop' component where
calculations in method '_getPointerPositionOnPage' was
incorrect in a situation when 'drag-drop' container has a fixed parent.

Fixes #15880

…as scrolled

Fixes a bug in Angular Material 'drag-drop' component where
calculations in method '_getPointerPositionOnPage' was
incorrect in situation when drag-drop container have fixed parent.

Fixes #15880
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Mar 2, 2020
@crisbeto
Copy link
Member

crisbeto commented Mar 2, 2020

There's a PR for this already: #14806

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Drag and Drop not working inside MatDialog (wrong previous and current index)
3 participants