Skip to content

build: update nodejs rules #14622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2019
Merged

build: update nodejs rules #14622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,8 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
# Add NodeJS rules (explicitly used for sass bundle rules)
http_archive(
name = "build_bazel_rules_nodejs",
# TODO(devversion): temporarily depend on a specific commit because we want to make sure that
# our CI is not flaky until there is a new version of the NodeJS rules. See commit:
# https://github.com/bazelbuild/rules_nodejs/commit/c40ceb960af4213164d4299d8fbc8220ebdd727f
url = "https://github.com/bazelbuild/rules_nodejs/archive/c40ceb960af4213164d4299d8fbc8220ebdd727f.zip",
strip_prefix = "rules_nodejs-c40ceb960af4213164d4299d8fbc8220ebdd727f",
url = "https://github.com/bazelbuild/rules_nodejs/archive/0.16.4.zip",
strip_prefix = "rules_nodejs-0.16.4",
)

# Add TypeScript rules
Expand Down Expand Up @@ -83,7 +80,7 @@ check_bazel_version("0.18.0")

node_repositories(
# For deterministic builds, specify explicit NodeJS and Yarn versions.
node_version = "10.10.0",
node_version = "10.13.0",
# Use latest yarn version to support integrity field (added in yarn 1.10)
yarn_version = "1.12.1",
)
Expand Down
1 change: 0 additions & 1 deletion tools/release/publish-release.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,6 @@ class PublishReleaseTask extends BaseReleaseTask {

/** Creates a specified tag and pushes it to the remote repository */
private createAndPushReleaseTag(tagName: string, releaseNotes: string) {
// TODO(devversion): find a way to extract the changelog part just for this version.
if (!this.git.createTag('HEAD', tagName, releaseNotes)) {
console.error(red(` ✘ Could not create the "${tagName}" tag.`));
console.error(red(` Please make sure there is no existing tag with the same name.`));
Expand Down