Skip to content

feat(mat-progress-spinner): Allow Default Color settings #24352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wratho opened this issue Feb 3, 2022 · 1 comment · Fixed by #24356
Closed

feat(mat-progress-spinner): Allow Default Color settings #24352

wratho opened this issue Feb 3, 2022 · 1 comment · Fixed by #24356
Labels
area: material/progress-spinner feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@wratho
Copy link

wratho commented Feb 3, 2022

Feature Description

Mat Progress Bar already supports { provide: MAT_PROGRESS_BAR_DEFAULT_OPTIONS, useValue: { color: 'accent' } },
can we get the same for spinner? for example:
{ provide: MAT_PROGRESS_SPINNER_DEFAULT_OPTIONS, useValue: { color: 'accent' } },

Use Case

Our design wants all progress indicators to be Accent by default. At the moment we are able to default the bar, but we must manually set color="accent" on spinners.
@wratho wratho added feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels Feb 3, 2022
lekhmanrus added a commit to lekhmanrus/components that referenced this issue Feb 4, 2022
@lekhmanrus
feat(material/progress-spinner): add color to default options
a59e317 
closes angular#24352
@lekhmanrus lekhmanrus mentioned this issue Feb 4, 2022
Merged
@crisbeto crisbeto added area: material/progress-spinner has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Feb 4, 2022
wagnermaciel pushed a commit that referenced this issue Feb 11, 2022
@lekhmanrus
feat(material/progress-spinner): add color to default options (#24356)
ca1aaae 
closes #24352
amysorto pushed a commit to amysorto/components that referenced this issue Feb 15, 2022
@lekhmanrus @amysorto
feat(material/progress-spinner): add color to default options (angula…
93057aa 
…r#24356)

closes angular#24352
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 14, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this issue Apr 3, 2022
@lekhmanrus @forsti0506
feat(material/progress-spinner): add color to default options (angula…
f920bc9 
…r#24356)

closes angular#24352
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: material/progress-spinner feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(material/progress-spinner): add color to default options lekhmanrus/components
2 participants
@crisbeto @wratho