Skip to content

In VoiceOver, aria-label on mat-radio-button is read twice #16913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
calebegg opened this issue Aug 29, 2019 · 3 comments · Fixed by #16938
Closed

In VoiceOver, aria-label on mat-radio-button is read twice #16913

calebegg opened this issue Aug 29, 2019 · 3 comments · Fixed by #16938
Assignees
Labels
Accessibility This issue is related to accessibility (a11y) G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@calebegg
Copy link

StackBlitz seems to be down, but it's easy to reproduce--just add an aria-label to any mat-radio-button. The label gets duplicated, and VO reads both.

image

@jelbourn
Copy link
Member

@calebegg add like which of these?

<mat-radio-button [aria-label]="...">

<!-- or -->

<mat-radio-button [attr.aria-label]="...">

@jelbourn jelbourn added Accessibility This issue is related to accessibility (a11y) needs: clarification The issue does not contain enough information for the team to determine if it is a real bug labels Aug 30, 2019
@calebegg
Copy link
Author

calebegg commented Aug 31, 2019 via email

@crisbeto crisbeto self-assigned this Sep 1, 2019
@crisbeto crisbeto added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Sep 1, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 1, 2019
If the `aria-*` attributes are set on the host node via static bindings, we can end up with both the host and the input having the same `aria-label` which might be read out by a screen reader. These changes clear the attributes from the host.

Fixes angular#16913.
@jelbourn jelbourn added G This is is related to a Google internal issue and removed needs: clarification The issue does not contain enough information for the team to determine if it is a real bug labels Sep 4, 2019
jelbourn pushed a commit that referenced this issue Sep 6, 2019
If the `aria-*` attributes are set on the host node via static bindings, we can end up with both the host and the input having the same `aria-label` which might be read out by a screen reader. These changes clear the attributes from the host.

Fixes #16913.
jelbourn pushed a commit that referenced this issue Sep 9, 2019
If the `aria-*` attributes are set on the host node via static bindings, we can end up with both the host and the input having the same `aria-label` which might be read out by a screen reader. These changes clear the attributes from the host.

Fixes #16913.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants