-
Notifications
You must be signed in to change notification settings - Fork 12k
feat: add typescript 3 as peer dependency and repo devDep #11889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -31,11 +31,10 @@ | |||
"webpack-sources": "^1.1.0" | |||
}, | |||
"peerDependencies": { | |||
"typescript": "~2.4.0 || ~2.5.0 || ~2.6.0 || ~2.7.0 || ~2.8.0 || ~2.9.0", | |||
"typescript": "~2.4.0 || ~2.5.0 || ~2.6.0 || ~2.7.0 || ~2.8.0 || ~2.9.0 || ~3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can shorten this to 2.4 - 3.0
This is blocked on support from @angular/compiler for TypeScript 3. |
Blocking issue in angular/angular#25275 Side note, it looks like Angular 7 will support only So maybe the defaults in the schematics should be re-thinked. |
Yeah we will update |
Superseded by #12046 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The default being created is still 2.9.2.