Skip to content

feat: add typescript 3 as peer dependency and repo devDep #11889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Aug 14, 2018

The default being created is still 2.9.2.

@hansl hansl added the target: major This PR is targeted for the next major release label Aug 14, 2018
@@ -31,11 +31,10 @@
"webpack-sources": "^1.1.0"
},
"peerDependencies": {
"typescript": "~2.4.0 || ~2.5.0 || ~2.6.0 || ~2.7.0 || ~2.8.0 || ~2.9.0",
"typescript": "~2.4.0 || ~2.5.0 || ~2.6.0 || ~2.7.0 || ~2.8.0 || ~2.9.0 || ~3.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can shorten this to 2.4 - 3.0

@hansl
Copy link
Contributor Author

hansl commented Aug 14, 2018

This is blocked on support from @angular/compiler for TypeScript 3.

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Aug 15, 2018

Blocking issue in angular/angular#25275

Side note, it looks like Angular 7 will support only TS 3+. Looking at the change @IgorMinar did angular/angular@f3eb7cf

So maybe the defaults in the schematics should be re-thinked.

@hansl
Copy link
Contributor Author

hansl commented Aug 17, 2018

Yeah we will update latestVersions when we need to.

@alan-agius4
Copy link
Collaborator

Superseded by #12046

@alan-agius4 alan-agius4 closed this Sep 6, 2018
@hansl hansl deleted the typescript-3 branch November 28, 2018 23:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants