This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix(Selectize): Input box is not hidden when selected data is 0 (as n… #1691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jefiozie Wouldn't it be better to check |
|
@user378230, i think you are right. Maybe it is even better to use the isEmpty function?
|
|
Yes, good spot! |
|
@user378230 okay will change it later today. |
|
@user378230, changed the code as discussed in the comments above. |
| @@ -8,7 +8,7 @@ | |||
| ng-click="$select.toggle($event)" | |||
| placeholder="{{$select.placeholder}}" | |||
| ng-model="$select.search" | |||
| ng-hide="!$select.searchEnabled || ($select.selected && !$select.open)" | |||
| ng-hide="!$select.searchEnabled || (($select.selected || !$select.isEmpty()) && !$select.open)" | |||
There was a problem hiding this comment.
Can't we can remove $select.selected now...?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…umber)
Closes #1304