Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Feature/disable backspace reset #1481

Closed
wants to merge 3 commits into from
Closed

Feature/disable backspace reset #1481

wants to merge 3 commits into from

Conversation

pierregaste
Copy link
Contributor

Add a new option that prevent the backspace key reset the model (set to undefined).
Th option could be added to the directive ui-select:

<ui-select disable-backspace-reset="true"></ui-select>

I hope I correctly commit and implement this feature! 😃


feat(uiSelectSingleDirective): add an option to avoid backspace model reset

Currently, when you select an option and you press the backspace key, it will reset the model.
With this option, we could disable this behavior to avoid the model resetting.

Closes #926 #525

Pierre Gasté added 2 commits March 9, 2016 11:34
… reset

Currently, when you select an option and you press the backspace key, it will reset the model.
With this option, we could disable this behavior to avoid the model resetting.

Closes #926 #525
@deeg
Copy link
Contributor

deeg commented Mar 16, 2016

I'm not sure how the other maintainers feel about adding this feature, but before it can be merged the PR will need to be squashed and rebased.

I will let @aaronroberson and @user378230 weigh in on if they think this is a feature they would want to merge.

@@ -1,3 +1,13 @@
<a name="0.14.10"></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this will get created automatically at build time once we fix everything up.

Please remove these changes from the file.

@deeg
Copy link
Contributor

deeg commented Mar 16, 2016

Also please remove the /dist files from the PR.

@pierregaste
Copy link
Contributor Author

I just rebased the PR. Is it OK for you?

@pierregaste pierregaste closed this Apr 5, 2016
@pierregaste pierregaste reopened this Apr 5, 2016
@user378230
Copy link
Contributor

Does this have any unit tests?

What issue is this actually trying to solve?

Can you provide:
- a plunkr based on current library and the problem (along with steps to follow)
- a plunkr with your changes and describe what difference this will make to the user

Thanks for your contribution but I can't merge and maintain changes I don't know anything about.

Apologies, I hadn't read your commit message.

@user378230
Copy link
Contributor

  • This still needs a test
  • Squashing to a single commit.
  • Can you rebase and add an example? It should be fairly easy to do. Examples have been moved to docs/examples now.
  • Can post here some documentation here which can be included in wiki when the PR is merged?

@pierregaste
Copy link
Contributor Author

I removed this fork by mistake.
Please go to #1736.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants