This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix: Allow setting a ngClass on <ui-select> element #1447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since a ngClass is already present in the uiSelect theme templates, we could not add any ngClass on <ui-select> without getting an JS error
Currently, adding a ngClass on <ui-select> result in:
`ng-class="{class: expression} {open: $select.open}"`
With this fix, doing the same thing result in:
`ng-class="{class: expression, open: $select.open}"`
Closes angular-ui#277
aaronroberson
added a commit
that referenced
this pull request
Feb 18, 2016
fix(ui-select): allow setting a ngClass on <ui-select> element
Since a ngClass is already present in the uiSelect theme templates, we could not add any ngClass on without getting an JS error
Currently, adding a ngClass on result in:
ng-class="{class: expression} {open: $select.open}"
With this fix, doing the same thing result in:
ng-class="{class: expression, open: $select.open}"
Closes #277
|
Even such a small change should have a test, imo. |
|
Agreed. @Magador can you add the test in another PR? |
|
Sure ! You'll have it by 12PM UTC tomorrow :) |
Magador
pushed a commit
to Magador/ui-select
that referenced
this pull request
Feb 19, 2016
… uiSelect compiles Add missing test from PR angular-ui#1447
Magador
pushed a commit
to Magador/ui-select
that referenced
this pull request
Feb 19, 2016
…uiSelect References PR angular-ui#1447 - Add missing test on uiSelect when merging ngClass attributes between DOM declaration and template - Add one property `attrs.ngClass` in `createUiSelect(attrs)` to append a `ng-class` attribute to the <ui-select> element
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a ngClass is already present in the uiSelect theme templates, we could not add any ngClass on without getting an JS error
Currently, adding a ngClass on result in:
ng-class="{class: expression} {open: $select.open}"With this fix, doing the same thing result in:
ng-class="{class: expression, open: $select.open}"Closes #277
Maybe I should write a test case ?