This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix(multiple): text input not resized on window resize #1183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have just made a PR fixing the same issue, just with a more general approach — #1252 . |
| $select.sizeSearchInput(); | ||
| } | ||
|
|
||
| angular.element($window).on('resize', onWindowResize); |
There was a problem hiding this comment.
This needs to be debounced.
|
This needs tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text input within multiple select is not resized correctly on window resize. Open this plunkr and try to resize window. Notice that text input (with green background) is not resized:
http://embed.plnkr.co/cqsb8nOIunj2rMU36z5H/preview
Here's the demo with this fix applied: http://embed.plnkr.co/pPdeELl80hgCOVZKCs6a/preview