fix(ui-grid-column-menu.js): Added keyboard navigation to column menu #6629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielDiTommaso
force-pushed
the
columnMenuA11y
branch
from
4f07b15 to
752bf6e
Compare
mportuga
reviewed
Mar 23, 2018
| } | ||
| }, visibleMenuItems); | ||
|
|
||
| if (visibleMenuItems.length) { |
There was a problem hiding this comment.
What happens if there is only a single column header menu item? For example the company column of the first grid in the plunker bellow:
http://plnkr.co/edit/?p=preview
It can be seen in the 102 Sorting tutorial.
mportuga
requested changes
Mar 23, 2018
Provided keydown handlers for uiGridColumnMenu so you can tab-cycle through the menu items correctly. Escape also now closes an open menu. fix angular-ui#5075
DanielDiTommaso
force-pushed
the
columnMenuA11y
branch
from
752bf6e to
a0a0392
Compare
mportuga
reviewed
Mar 23, 2018
| if (visibleMenuItems.length) { | ||
| if (visibleMenuItems.length === 1) { | ||
| visibleMenuItems[0].onkeydown = function singleItemHandler(event) { | ||
| circularFocusHandler(event, true); |
There was a problem hiding this comment.
Can't you just call event.preventDefault directly here?
There was a problem hiding this comment.
Never mind, I talked to you in person and see the if statement.
mportuga
approved these changes
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provided keydown handlers for uiGridColumnMenu so you can tab-cycle through the menu items
correctly. Escape also now closes an open menu.
fix #5075