Fix for Issue: #5101 - enableColumnResizing accumulates watchers with each table $digest cycle #5933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jedancona Can you add unit tests for your removeResizers function? |
|
Added unit testing by calling the destroying the scope and checking the length of watchers. The previous code leaves a watcher behind. The new code does not leave a watcher behind. |
|
What about this PR? It fixes an important scope leak inside the grid which causes significant performance degredation after a time |
mportuga
approved these changes
Mar 3, 2017
vishalnarewade
pushed a commit
to vishalnarewade/ui-grid
that referenced
this pull request
Nov 6, 2017
…atchers with each table $digest cycle (angular-ui#5933)" This reverts commit 954beba.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue: enableColumnResizing accumulates watchers with each table $digest cycle #5101.
#5101
Creates a new scope for each resizer, stores them into an array so that the scopes can be destroyed before resetting the resizers.