fix(modifyRows): modifyRows uses the new entity when using enableRowHashing #5917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremytowne
reviewed
Dec 29, 2016
|
|
||
| expect(grid.rows.length).toBe(1); | ||
| function testInitialChange() { |
There was a problem hiding this comment.
Is it necessary to run this in every test? Shouldn't this just but one 'it'?
There was a problem hiding this comment.
good point. I will make that change.
|
@jeremytowne I made the change you suggested |
jeremytowne
approved these changes
Dec 29, 2016
…RowHashing - idangozlan
dlgski
approved these changes
Dec 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using enableRowHashing (which is set right now to true as default), modifyRows match the old and the new row but not using the new entity at all.
Credit to @idangozlan for the fix. This PR merely adds unit tests to his work.