fix(core): check for undefined on sort priority

[dlgski]

in Issue #4876 isSortPriorityVisible() is introduced. However it is testing the variable rather than for undefined, so when element.sort.priority == 0, it is returning as false, even though that should return true.

This update is adding the checks for undefined

@jbarrus @JLLeitschuh

[dlgski]

A better fix for this would be to index sort.priority at 1 rather than 0, but I cannot find where sort.priority is getting initially set to 0.

If sort.priority was indexed at 1, then this code would have worked the way it was. Also, having an indicator of "0" looks kind of odd. (which this will result with)

[swalters]

Would this PR fix the issue? #4807

[dlgski]

I added some comments to that PR. If that PR is indexing sortPriority at
1, then I think these checks will properly return "true" when sortPriority
exists

On Thu, Jan 21, 2016 at 5:16 PM, Shane Walters notifications@github.com
wrote:

Would this PR fix the issue? #4807
#4807

—
Reply to this email directly or view it on GitHub
#5000 (comment).

[JLLeitschuh]

This makes sense since 0 would evaluate to false in this case. Okay, cool Thanks.