Skip to content

Fixed column-moving issue #3652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fixed column-moving issue #3652

wants to merge 4 commits into from

Conversation

belskiyvv
Copy link
Contributor

Fixed column-moving issue for tables with horizontal scroll and for IE11.

Review on Reviewable

@swalters swalters assigned swalters and PaulL1 and unassigned swalters Jun 18, 2015
@swalters
Copy link
Contributor

Hi @belskiyvv could you explain what wasn't working in IE11 and how this fixes it?

@belskiyvv
Copy link
Contributor Author

Hi @swalters
with ".movingColumn { position: absolute;}" it work fine in all browsers for table without scroll
but if table with scroll, this feature working wrong.
It may be fixed, if set "position: fixed;" . But then it working wrong in IE 11.

Sorry for my english, please see the this video (column-moving bug in chrome): https://drive.google.com/file/d/0B9IzvGgonTIaZWhtMFJtZVVmOTg/edit
and this gif (IE11 with "position: fixed;"):
http://gyazo.com/2ca6c19e3e674791fdb0f459dde11a3d

With "position: absolute;" bug occurs because .getBoundingClientRect() returns incorrect values
I used .offsetLeft and .offsetWidth properties..

@miah-al
Copy link
Contributor

miah-al commented Aug 16, 2015

Any chance of this PR getting merged?

@belskiyvv
Copy link
Contributor Author

@thomashilzendegen, thank you for review. JQuery was removed.

@mermonkey
Copy link

Is this abandoned or still getting integrated? Will it help with #3448? cheers!

@tomaszczechowski
Copy link

Can we merge please? It's quite annoying issue.

Thanks!

@AgDude
Copy link
Contributor

AgDude commented Jul 30, 2016

Closing, as this hasn't seen activity in a long time, tests are failing, and does not meet our single commit per PR requirement.

@AgDude AgDude closed this Jul 30, 2016
@AgDude
Copy link
Contributor

AgDude commented Jul 30, 2016

see also #4006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants