Refactor(styleComputations): fixes rendercontainer rendering problems #3145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the style computations with the aim of making them deterministic and able to calculate widths in a single pass rather than being iterative. Fix angular-ui#3050, and somewhat improves angular-ui#1957, at least to my eye. Changes are: - change renderContainer updateColumnWidths to calculate across all visible columsn in all render containers, rather than trying to calculate one render container at a time (cannot otherwise work with * and %, these are of the whole grid, not just one render container) - change header updateColumnWidths to just rely on the renderContainer, not do it again itself in a slightly different way - change updateColumnWidths to be simpler, and to calculate percentages in a way that I think makes more sense - change resize feature to not attempt to 'resizeAround' the changed column, but rather allow updateColumnWidths to deal with it - change pinning to not call refresh twice when moving a column, this is now unnecessary - updates to tutorials
PaulL1
added a commit
that referenced
this pull request
Mar 28, 2015
Refactor(styleComputations): fixes rendercontainer rendering problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the style computations with the aim of making them deterministic
and able to calculate widths in a single pass rather than being iterative.
Fix #3050, and somewhat improves #1957, at least to my eye.
Changes are:
visible columsn in all render containers, rather than trying to calculate
one render container at a time (cannot otherwise work with * and %, these are of
the whole grid, not just one render container)
do it again itself in a slightly different way
that I think makes more sense
rather allow updateColumnWidths to deal with it
unnecessary