Fix #2542 (renderContainer): mis-render on 401 on initial render #2571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ender Sometimes width of the header or the canvas were calculated as NaN, which looks to be a race condition. Two fixes: - Use width when drawnWidth not available. Will potentially fail if with is '*' or a percentage, but seems to work fine for now - Call updateWidth if width isn't present
PaulL1
added a commit
that referenced
this pull request
Jan 16, 2015
Fix #2542 (renderContainer): mis-render on 401 on initial render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes width of the header or the canvas were calculated as NaN,
which looks to be a race condition. Two fixes:
if with is '*' or a percentage, but seems to work fine for now