Regression Fix for #2357 the scrollPercentage is not correct

[jcompagner]

if there are added rows, because then the scrollPercentage should be recalculated.

so its an enhancement on this fix:
bc2c68a

[jcompagner]

maybe there is a better way of doing this? But if there are added rows then the canvas size is getting bigger and the current stored percentage is not correct

for example look at the current code of http://ui-grid.info/docs/#/tutorial/212_infinite_scroll
if you scroll completely down then the scroll percentage is going to be "1" but at that time loads of new rows are added it so it should jump to lets say 0.7

In that example you can see that the screens is getting blank because of this, because the currentRow calculation is done with scroll percentage closed to 1

[c0bra]

The fix seems to work well, but I'm hesitant to introduce more methods that have boolean flags as it's probably a code smell. In fact, we should probably refactor the ones we have.

What about breaking this into two methods, something like redrawAtScrollPercentage and redrawAtScrollPixels? Thoughts?

[jcompagner]

that sounds nice to me.
I guess you can alter my fix? or do you need a pull request?

[c0bra]

I've merged e497eac. Thanks @jcompagner!