Skip to content

Typo's in i18n/de.js -> gridMenu #6610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Simsal opened this issue Mar 16, 2018 · 1 comment · Fixed by #6611
Closed

Typo's in i18n/de.js -> gridMenu #6610

Simsal opened this issue Mar 16, 2018 · 1 comment · Fixed by #6611

Comments

@Simsal
Copy link
Contributor

Simsal commented Mar 16, 2018

Found some errors in german translation:

  • exporterVisibleAsExcel: 'sichtbare Daten als Excel exportiere' -> missing n at the end. also it is weird that the command starts lowercase
  • same with the other commands. Some start with uppercase ('Alle') and only visible ('sichtbare') are lowercase

If you are open to it, i would send in a pull request tomorrow.
@mportuga
Copy link
Member

A pull request would be much appreciated.

Simsal added a commit to Simsal/ui-grid that referenced this issue Mar 17, 2018
@Simsal
fix(i18n)change some strings in de.js due to typos
0b33e98 
change strings in gridMenu. Capitalized each first letter, added a
missing 'n'. Also added a missing 'e' at pagination - pageSelected

closes angular-ui#6610
@Simsal Simsal mentioned this issue Mar 17, 2018
Merged
mportuga pushed a commit that referenced this issue Mar 19, 2018
@Simsal @mportuga
fix(i18n)change some strings in de.js due to typos
9ebe116 
change strings in gridMenu. Capitalized each first letter, added a
missing 'n'. Also added a missing 'e' at pagination - pageSelected

closes #6610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(i18n)change some strings in de.js due to typos Simsal/ui-grid
2 participants
@mportuga @Simsal