Skip to content

ScrollToFocus not showing entire new row (with important height) #6563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
isylhdin opened this issue Feb 2, 2018 · 0 comments · Fixed by #6644
Closed

ScrollToFocus not showing entire new row (with important height) #6563

isylhdin opened this issue Feb 2, 2018 · 0 comments · Fixed by #6644
Labels
good first issue

Comments

@isylhdin
Copy link

isylhdin commented Feb 2, 2018

angular-ui-grid version : 4.2.3

Row heigth : 120

When I add a new row and scrollToFocus is called to focus the new row => new row is not visible entirely

Plunker : http://plnkr.co/edit/xpWrdtulib0ShnaScoDj?p=preview
mportuga pushed a commit that referenced this issue Mar 28, 2018
fix(Grid.js): scrollToIfNecessary can scroll to last row.
cdaa300 
Updated the scrollToIfNecessary to treat any percentage number for the scroll position that is
greater than 1 as 1.

fix #6571, fix #6507, fix #6563
@mportuga mportuga mentioned this issue Mar 28, 2018
Merged
mportuga pushed a commit that referenced this issue Mar 28, 2018
@mportuga
fix(Grid.js): scrollToIfNecessary can scroll to last row.
87c9eed 
Updated the scrollToIfNecessary to treat any percentage number for the scroll position that is
greater than 1 as 1.

fix #6571, fix #6507, fix #6563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Grid.js): scrollToIfNecessary can scroll to last row. angular-ui/ui-grid
2 participants
@isylhdin @mportuga