Skip to content

Scrollbar issue in version 4.3 #6280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
achenxp opened this issue Jun 20, 2017 · 4 comments · Fixed by #6612
Closed

Scrollbar issue in version 4.3 #6280

achenxp opened this issue Jun 20, 2017 · 4 comments · Fixed by #6612
Assignees
@mportuga

Comments

@achenxp
Copy link

achenxp commented Jun 20, 2017

When a column is pinned with no horizontal scrollbar showing for unpinned columns, the pinned column still shows scrollbar placeholder which makes the grid look odd. http://plnkr.co/edit/kRAvZljoYqyX4QiHe2Vh?p=preview
@lenkaK
Copy link

lenkaK commented Jul 26, 2017 •
edited
Loading

Problem is in ui-grid.js in method getViewportStyle() on lines 9003 and 9004.
styles['overflow-x'] = self.hasHScrollbar ? 'auto' : 'hidden';. In previous version of ui-grid there was 'scroll' instead of 'auto'.

@MatejQ
Copy link
Contributor

MatejQ commented Jul 27, 2017

+1 for a fix

@cybermerlin
Copy link
Contributor

i have fixed in
https://github.com/cybermerlin/ui-grid/tree/develop

@mportuga mportuga self-assigned this Mar 16, 2018
@achenxp achenxp changed the title Scrollbar issue in version 4.0.6 Scrollbar issue in version 4.3 Mar 19, 2018
@achenxp
Copy link
Author

achenxp commented Mar 19, 2018

Still doesn't look right with WHEN_NEEDED option specified while horizontal scrollbar is showing with pinned column. Scroll to the bottom, and you'll see the rows are not aligned between pinned and unpinned columns.
http://plnkr.co/edit/zHldTgH6BFK9lOu4cgIq?p=preview

DanielDiTommaso pushed a commit to DanielDiTommaso/ui-grid that referenced this issue Mar 19, 2018
fix(GridRenderContainer.js): needsHScrollbarPlaceholder accounts for …
52ce405 
…WHEN_NEEDED

Added logic to needsHScrollbarPlaceholder to account for left/right rendercontainers as well as
handle case when gridOption enableHorizontalScrollbar is set to WHEN_NEEDED.

fix angular-ui#6280, fix angular-ui#5812, fix angular-ui#5760, fix angular-ui#6590, fix angular-ui#6572, fix angular-ui#6528, fix angular-ui#4251, fix angular-ui#3022
@DanielDiTommaso DanielDiTommaso mentioned this issue Mar 19, 2018
Merged
mportuga pushed a commit that referenced this issue Mar 19, 2018
@mportuga
fix(GridRenderContainer.js): needsHScrollbarPlaceholder accounts for …
403bf3e 
…WHEN_NEEDED

Added logic to needsHScrollbarPlaceholder to account for left/right rendercontainers as well as
handle case when gridOption enableHorizontalScrollbar is set to WHEN_NEEDED.

fix #6280, fix #5812, fix #5760, fix #6590, fix #6572, fix #6528, fix #4251, fix #3022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mportuga mportuga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(WHEN_NEEDED): needsHScrollbarPlaceholder accounts for WHEN_NEEDED DanielDiTommaso/ui-grid
5 participants
@cybermerlin @mportuga @achenxp @MatejQ @lenkaK