Skip to content

Expandable grids freak out when resized #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mburbea opened this issue Nov 12, 2014 · 11 comments
Closed

Expandable grids freak out when resized #2074

mburbea opened this issue Nov 12, 2014 · 11 comments
Milestone

Comments

@mburbea
Copy link
Contributor

mburbea commented Nov 12, 2014

If a grid is configured to have expandable option and re-sizable when you resize the grid it will "freak out" and bounce out of its container when you reduce the amount of space for the grid. This issue happens in chrome 38, IE 11 and firefox 26.
I've captured a screenshot.
image

@jmorrisIII
Copy link

Maybe similar to this #2063

@mburbea
Copy link
Contributor Author

mburbea commented Nov 12, 2014

This seems to be related to #1947 actually.

@PaulL1 PaulL1 added this to the 3.0 milestone Nov 12, 2014
@c0bra
Copy link
Contributor

c0bra commented Nov 13, 2014

@mburbea is this is a transient "flash" or does it persist after resizing? You can post a comment on #1947.

@mburbea
Copy link
Contributor Author

mburbea commented Nov 13, 2014

Its a transient flash but it lasts for a noticeable amount of time.

@j-walker23
Copy link

@c0bra If you had time to look into this where would you start?

@PaulL1
Copy link
Contributor

PaulL1 commented Nov 24, 2014

Not @c0bra, but I did look at a similar issue at one point, which came down to the order in which things were being rendered. The rendering wasn't taking the pinned column (and therefore the left render container) into account when first rendering, so we got a flash of the two renderContainers one above the other.

That issue was resolved in #1848 and #1849, so the changes I made in there might give some hints.

It's much harder to address on resize, as it's so transient. With the initial render that I looked at I could at least set a breakpoint and then step through the widths of the left and body render containers, and the overall canvas. Ultimately the problem was to do with the "adjusters" which tell the body render container to leave space for the pinned columns. It wouldn't surprise me if that were also the issue here.

I guess you could head for a console.log on the width of those two containers, or write out some information from GridRenderContainer.getViewportWidth - likely that would give some tips as to what is going on.

@PaulL1
Copy link
Contributor

PaulL1 commented Jan 16, 2015

I fixed #1957, which was a similar issue to do with pinned columns. I suspect it has also fixed this one, could you retest?

@mburbea
Copy link
Contributor Author

mburbea commented Jan 20, 2015

I'll check it out I've not tried using the project from sources before.

@PaulL1
Copy link
Contributor

PaulL1 commented Feb 6, 2015

Any progress with checking this out?

@mburbea
Copy link
Contributor Author

mburbea commented Feb 6, 2015

Sorry, I'm no longer using ui grid so I haven't had a chance to try this
bug out.
On Feb 6, 2015 3:17 AM, "Paul" notifications@github.com wrote:

Any progress with checking this out?


Reply to this email directly or view it on GitHub
#2074 (comment).

@PaulL1
Copy link
Contributor

PaulL1 commented Feb 6, 2015

OK, I'll assume that it's covered then, it will get re-raised if someone else sees it again.

@PaulL1 PaulL1 closed this as completed Feb 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants