Unmet peer dependency

[pronebird]

npm i eslint-config-airbnb --save-dev

├─┬ eslint-config-airbnb@14.0.0
│ ├── eslint-config-airbnb-base@11.0.1
│ └── UNMET PEER DEPENDENCY eslint-plugin-import@^2.2.0
├── UNMET PEER DEPENDENCY eslint-plugin-import@^2.2.0
├── UNMET PEER DEPENDENCY eslint-plugin-jsx-a11y@^3.0.2
└── UNMET PEER DEPENDENCY eslint-plugin-react@^6.9.0

Why is it broken?

[ljharb]

Please use the install command in the package readme; this will install the correct peer dependencies.

[just-boris]

By the way it worth mentioning, that NPM 3+ will not install peer dependencies for you. You need to explicitly declare them in your package.json

@ljharb why do you keep them as peers? The most common use case for the code-style will be npm install -D eslint-config-airbnb, then write {"extends": "airbnb"}, and you will be set.
Currently, you need to do an extra step and install those dependencies as well. package.json of average project becomes longer and longer.

[ljharb]

@just-boris eslint requires that it work that way; if they're not peers, none of the rules will work or be overrideable.

[just-boris]

Do you mean the issue: eslint/eslint#3458?

Thanks for explanation, now I understand why do I need to do so.

[gazpachu]

@pronebird @just-boris @ljharb I still have problems to have the latest version working.

I get this error message (in Atom) everytime I open a file: /node_modules/eslint-config-airbnb/rules/react-a11y.js: Configuration for rule "jsx-a11y/href-no-hash" is invalid: Value "[object Object]" no (or more than one) schemas match. Referenced from: airbnb Referenced from: /Users/martosj/Dev/Webs/commit-frontend/.eslintrc.js

These are the packages I'm using:

"eslint": "^3.15.0",
"eslint-config-airbnb": "^14.0.0",
"eslint-plugin-import": "^2.2.0",
"eslint-plugin-jsx-a11y": "^3.0.2 || ^4.0.0",
"eslint-plugin-react": "^6.9.0",

This is my .eslintrc.js:

module.exports = {
  "extends": "airbnb",
  "rules": {
    "indent": [2, "tab", { "SwitchCase": 1, "VariableDeclarator": 1 }],
      "react/prop-types": 0,
      "react/jsx-indent": [2, "tab"],
      "react/jsx-indent-props": [2, "tab"],
      "comma-dangle": ["error", "never"]
  },
  "globals": {
    "document": true,
    "window": true
  }
}

[ljharb]

Are you sure the versions on disk are correct, and that you've restarted atom? What's npm ls say?

[gazpachu]

Oh dear, yeah, restarting Atom fixed it 👍
On the other hand, I get now 'Unexpected tab character (no-tabs) whereas with the previous version, it was working fine. Any idea?

[pronebird]

I think we can close this issue since as it turned out peer deps have to be installed manually. Thanks for all help!

[ljharb]

@gazpachu that seems like eslint updated to catch an error it was missing before. I'd just fix your code.

[gazpachu]

@ljharb I'm afraid that's not the case. If I remove the tab, I get this:

And if I add the tab, I get this:

And that's happening to all lines of all files :/

I've tried to remove the rules section in the eslintrc.js file but nothing changes.

[ljharb]

Do you use tabs or spaces for indentation?

[gazpachu]

tabs

[ljharb]

In that case, you need to disable the no-tabs rule entirely. Airbnb uses spaces, so the guide comes configured to ban all tab characters.