Skip to content

6.2 contradicts 18.12 #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AskYous opened this issue Aug 22, 2016 · 1 comment
Closed

6.2 contradicts 18.12 #1027

AskYous opened this issue Aug 22, 2016 · 1 comment

Comments

@AskYous
Copy link

AskYous commented Aug 22, 2016

6.2 says that strings over 100 characters should not be split into new lines. 18.12 says they should be. Both provide contradicting examples.

6.2:

// good
const errorMessage = 'This is a super long error that was thrown because of Batman. When you stop to think about how Batman had anything to do with this, you would get nowhere fast.';

18.12:

// bad
const foo = 'Whatever national crop flips the window. The cartoon reverts within the screw. Whatever wizard constrains a helpful ally. The counterpart ascends!';
@ljharb
Copy link
Collaborator

ljharb commented Aug 22, 2016

Thanks - we definitely should update https://github.com/airbnb/javascript#whitespace--max-len so that "long line" examples are not composed of long strings.

@ljharb ljharb self-assigned this Aug 23, 2016
@ljharb ljharb closed this as completed in 21846f6 Aug 23, 2016
ramasilveyra pushed a commit to auth0/javascript that referenced this issue Dec 6, 2016
hibearpanda pushed a commit to 15Prospects/javascript that referenced this issue Jan 22, 2017
jaylaw81 pushed a commit to appirio-digital/ads-best-practices that referenced this issue Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants