Fix author extraction for single-line declarations(#4229) #4234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alok1304
force-pushed
the
issue-4229-author-detection
branch
5 times, most recently
from
7374632 to
66dba8f
Compare
|
still in this worked fine but due to this, we got many false positive detections. like for |
alok1304
force-pushed
the
issue-4229-author-detection
branch
9 times, most recently
from
19b76b5 to
1630148
Compare
Reference: aboutcode-org#4229 Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
no need to remove single plus sign Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
If any single word whose first letter is capital and also having dot(.) between word then consider as NNP. Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
alok1304
force-pushed
the
issue-4229-author-detection
branch
from
34f3ded to
e104aff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4229
Currently, I did these things:
1. Split tokens on colons (
:)Previously, entries like
Author:Frankie.Chuwere treated as a single token. I updated the tokenizer to split on:so thatAuthorandFrankie.Chuare recognized as separate tokens.2. Remove leading plus sign from author token
There is no support for leading
+in author token like#+AUTHOR: Lee Hinman, I removed the leading plus sign from the author token+AUTHOR. There are 45k+ file used these this, these.orgfile see https://github.com/search?q=%22%2Bauthor%3A%22&type=code&p=5Tasks
Run tests locally to check for errors.
Signed-off-by: Alok Kumar alokkumarjipura9973@gmail.com