This repository was archived by the owner on Apr 25, 2025. It is now read-only.
[interpreter/tests] Switch to Option B' #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titzer
reviewed
Oct 16, 2023
interpreter/syntax/ast.ml
Outdated
| instr list option (* catch_all *) | ||
| | TryDelegate of block_type * instr list * (* try *) | ||
| var (* delegate to outer handler *) | ||
| | Try of block_type * catch list * instr list (* try *) |
There was a problem hiding this comment.
Do you want to keep the name TryTable internally to better match the text format?
|
Anybody willing to approve this PR? |
* [legacy] Create specification doc for legacy exception handling * [test] Create infra for legacy tests
|
Okay, I'm taking the liberty to land this for now, since some people complained, and it's not good if we keep the main doc out of date for longer. @aheejin, I'm happy to iterate in a follow-ups if you have comments later. |
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the branch with the B' design (explainer, interpreter, tests) into main.
It should be merged along with #283, which updates the spec document, and #284, which adds a new document describing the previous semantics plus respective tests.