Skip to content
This repository was archived by the owner on Apr 29, 2021. It is now read-only.

[Feature] Add Drag and Drop feature between UnityObject and UIWidgets #253

Merged
merged 12 commits into from
Jul 18, 2019
Merged

[Feature] Add Drag and Drop feature between UnityObject and UIWidgets #253

merged 12 commits into from
Jul 18, 2019

Conversation

IIzzaya
Copy link
Contributor

@IIzzaya IIzzaya commented Jul 16, 2019

  • [Feature] Add Drag and Drop new feature between UnityObject and UIWidgets
  • [Sample] Add a Drag and Drop Sample in Menu UIWidgetsTests/Drag&Drop/DragNDropSample

zhuxingwei
zhuxingwei suggested changes Jul 17, 2019
View reviewed changes
Runtime/gestures/mouse_tracking.cs
public void attachAnnotation(MouseTrackerAnnotation annotation) {
this._trackedAnnotations[annotation] = new _TrackedAnnotation(annotation);
this._scheduleMousePositionCheck();
#if UNITY_EDITOR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is called on an UIWidgetPanel (not an EditorWindow), the _scheduleDragFromEditorMousePositionCheck will still be triggered? maybe we should make sure this wouldn't happen?

Could we find a way to ensure that all the dragFromEditor relevant logics would never run outside an EditorWindow?

@zhuxingwei zhuxingwei merged commit 2cfaa8c into UnityTech:master Jul 18, 2019
@zhuxingwei zhuxingwei mentioned this pull request Jul 18, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zhuxingwei zhuxingwei zhuxingwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IIzzaya @zhuxingwei