This repository was archived by the owner on Apr 29, 2021. It is now read-only.
GC optimization on renderer #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optimize some new with cache remove lambda function (which will generate 10K gc per frame)
(1) create uiPicture and uiDrawCmds
replace delegates
MeshKey, MeshInfo => PoolItem
eliminate the use of dictionary/list in poolitemmanager
fix bug: scene builder build twice when compositeFrame
…er being cached in uiPath
yczhangsjtu
reviewed
Jul 5, 2019
try to keep the object pool as small as possible
adjust folder structure (move renderer out of utils)
# Conflicts: # Runtime/ui/painting/canvas_impl.cs # Runtime/ui/painting/txt/mesh_generator.cs # Runtime/ui/renderer/compositeCanvas/flow/physical_shape_layer.cs
…r2 (cont.) # Conflicts: # Runtime/ui/painting/canvas_impl.cs # Runtime/ui/painting/txt/mesh_generator.cs # Runtime/ui/renderer/compositeCanvas/flow/physical_shape_layer.cs
disable fast shadow
zhuxingwei
changed the title
# Conflicts: # Runtime/ui/painting/canvas_impl.cs
…r2 (CONT.) # Conflicts: # Runtime/ui/painting/canvas_impl.cs
yczhangsjtu
reviewed
Jul 15, 2019
| Paint paint2 = new Paint {color = spotColor}; | ||
| canvas.setMatrix(_shadowMatrix); | ||
|
|
||
| _shadowPaint.color = new Color(spotColor.value); |
There was a problem hiding this comment.
我的理解是_shadowPaint重用了所有的Paint，用不用给Paint增加一个reset()函数？
There was a problem hiding this comment.
嗯嗯，主要是出于GC的考虑所以都复用的这同一个Paint。Paint主要是framework层在用，大部分使用都考虑没有复用的需求。因此reset这个接口的用处暂时不大。我们可以之后优化framework层的时候再添加？
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.