Scripting memory capture - static field byte reporting fix #1065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atic fields being reported as present. * changed class crawling to be recursive and now store non inited classes * metadata type reporting will now also report invalid uninitialized types * metadata type reporting will now account for array types being fields inside a class
|
Just a heads up, the new clang formatting got picked up so I let it do it's thing ^_^ |
joncham
reviewed
Nov 6, 2018
mono/metadata/unity-memory-info.c
Outdated
| if (!g_hash_table_lookup_extended (context->allTypes, klass, &orig_key, &value)) | ||
| g_hash_table_insert (context->allTypes, klass, GINT_TO_POINTER (context->currentIndex++)); | ||
|
|
||
| fieldCount = mono_class_num_fields (klass); |
There was a problem hiding this comment.
Do we always want to do this, or only if the insert succeeds?
There was a problem hiding this comment.
oh ops only if it succeeds fixing up, also making sure we don't do the extra lookup there, fixed in cs
90bf666
…ash table. changed code so we avoid an extra lookup
joncham
reviewed
Nov 7, 2018
joncham
approved these changes
Nov 7, 2018
lukaszunity
approved these changes
Nov 8, 2018
realek
added a commit
that referenced
this pull request
Nov 15, 2018
*added missing include which caused the function signature to be int thus downcasting the pointer from 64 bit to 32
UnityAlex
pushed a commit
that referenced
this pull request
Dec 19, 2018
*added missing include which caused the function signature to be int thus downcasting the pointer from 64 bit to 32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for case 984330, static field bytes being reported without any static fields being reported as present when the static field would be one an array type or generic type instance.