Skip to content

fix: small issues related to comments #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

fix: small issues related to comments #1520

merged 1 commit into from
Mar 12, 2025

Conversation

YousefED
Copy link
Collaborator

  • removes dependency + check for collaboration, so theoretically you should be able to use comments without yjs
  • removes blocknoteIgnore (wasn't used, we directly use a property on the mark spec)

@YousefED YousefED requested a review from nperez0111 March 12, 2025 08:02
Copy link

vercel bot commented Mar 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Mar 12, 2025 8:15am
blocknote-website ✅ Ready (Inspect) Visit Preview Mar 12, 2025 8:15am

Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@nperez0111 nperez0111 merged commit df567b9 into main Mar 12, 2025
11 checks passed
@nperez0111 nperez0111 deleted the fix/comment-cleanup branch March 12, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants