Skip to content

fix: resolve unneeded error being thrown #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

fix: resolve unneeded error being thrown #1503

merged 1 commit into from
Mar 6, 2025

Conversation

nperez0111
Copy link
Contributor

Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Mar 6, 2025 8:11am
blocknote-website ✅ Ready (Inspect) Visit Preview Mar 6, 2025 8:11am

Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, do you also know why this could happen? (i.e.: could it indicate there's a different bug or are there expected scenarios?)

@nperez0111
Copy link
Contributor Author

nice, do you also know why this could happen? (i.e.: could it indicate there's a different bug or are there expected scenarios?)

The drag over handler is listening to the root element, so you are not guaranteed to be hovering over a table:

pmView.root.addEventListener(
"dragover",
this.dragOverHandler as EventListener
);
in which case, the previous state should still be maintained for the drop to actually switch the rows

@nperez0111 nperez0111 merged commit 70a832e into main Mar 6, 2025
7 checks passed
@nperez0111 nperez0111 deleted the fix/sentry-bug branch March 6, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants