Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

Add graphviz in Dockerfile #180

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Add graphviz in Dockerfile #180

merged 3 commits into from
Sep 18, 2020

Conversation

MaxDesiatov
Copy link
Contributor

graphviz is not currently installed, which triggers warnings when running the corresponding GitHub Action.

@mattt
Copy link
Contributor

mattt commented Sep 18, 2020

Thanks for the PR, @MaxDesiatov. I would have sworn that this was already in there, but I'm probably conflating adding GraphViz as a dependency in the Homebrew formula. Anyway, glad to have this fixed, and looking forward to having this available in the forthcoming release.

@MaxDesiatov
Copy link
Contributor Author

Thanks, I also have a prebuilt image here that I'm using in the meantime to make the action run faster, just in case you're interested https://hub.docker.com/r/maxdesiatov/swift-doc

I hope you could upload the official one in your Docker Hub namespace at some point.

@MaxDesiatov
Copy link
Contributor Author

(This required me to create two separate Dockerfiles in my swift-doc fork, one for the prebuilt image, the other for the action that only references the prebuilt image and does nothing else)

@mattt
Copy link
Contributor

mattt commented Sep 18, 2020

@MaxDesiatov

Thanks, I also have a prebuilt image here that I'm using in the meantime to make the action run faster, just in case you're interested https://hub.docker.com/r/maxdesiatov/swift-doc

I hope you could upload the official one in your Docker Hub namespace at some point.

That's great! Let's continue this discussion on #111.

@mattt mattt merged commit 2382ebc into SwiftDocOrg:master Sep 18, 2020
@MaxDesiatov MaxDesiatov deleted the patch-2 branch September 18, 2020 21:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants