Skip to content

fix handling g of duplicate speciesReference #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 27, 2023

Conversation

paulflang
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #127 (72205cf) into main (f700d96) will increase coverage by 5.01%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   89.10%   94.11%   +5.01%     
==========================================
  Files           6        6              
  Lines         312      323      +11     
==========================================
+ Hits          278      304      +26     
+ Misses         34       19      -15     
Impacted Files Coverage Δ
src/reactions.jl 97.45% <89.47%> (+3.06%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulflang
Copy link
Member Author

This PR fixes #118

@paulflang
Copy link
Member Author

@ArnoStrouwen can you approve this PR if it fixes the problem with your model?

@paulflang paulflang requested a review from ArnoStrouwen April 27, 2023 10:55
Copy link
Member

@ArnoStrouwen ArnoStrouwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not crash on the private example shared with us.

@paulflang paulflang merged commit 3023a88 into main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants