Skip to content

chore: fix Carthage submodule structure and SPM xcodeproj structure #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2021

Conversation

thedavidharris
Copy link
Contributor

@thedavidharris thedavidharris commented Jan 7, 2021

This address multiple issues that were affecting the xcodeproj, depending how it was used:

  • There's a .gitmodules file present but the submodule doesn't exist, as there's not .git/modules entry. This adds the submodule, properly linked with Carthage's install process.
  • The xcodeproj was looking for the "rxswift6" branch of RxSwift, instead of using the 6.0.0 release, so opening the xcodeproj file would fail, as it wasn't in sync with the actual Project.swift file in the repo. This also has the side affect of static linking RxSwift into RxDataSources, which then causes any parent binary that links both RxSwift and RxDataSources to crash because of the known symbol demangling issue. SwiftPM builds are not affected since the relies on the Package.swift.

@thedavidharris
Copy link
Contributor Author

This seems to only be failing for Xcode 11.5 and I'm unsure as to why

@balitm balitm mentioned this pull request Jan 22, 2021
Copy link
Member

@freak4pc freak4pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! I'm ok with the CI failure. Guaranteeing Xcode 11 support isn't a priority right now.

@freak4pc freak4pc merged commit e4627ac into RxSwiftCommunity:main Mar 25, 2021
@rxswiftcommunity
Copy link

Thanks a lot for contributing @thedavidharris! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants