Skip to content

Upgraded EventEmitter2 and removed shim #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 7, 2016
Merged

Upgraded EventEmitter2 and removed shim #221

merged 3 commits into from
Dec 7, 2016

Conversation

eadlam
Copy link
Contributor

@eadlam eadlam commented Apr 7, 2016

I upgraded the EventEmitter2 version in package.json and removed the shim. This allows roslibjs to be used in webpack projects.

@rctoris
Copy link
Contributor

rctoris commented Apr 9, 2016

Looks like no API changes which is awesome, have you run all of the examples?

@Rayman
Copy link
Contributor

Rayman commented Apr 18, 2016

@bduffany
Copy link

Status on this? I'm trying to use roslibjs with webpack as well and this PR solves my problems (I think).

@jihoonl
Copy link
Member

jihoonl commented Aug 10, 2016

Hi @eadlam, it looks like this PR was in conflict for a while. Could you rebase and apply @Rayman 's comments?

@subvertallchris
Copy link

Hey guys, would love to use this if anyone can finish it up.

@jihoonl jihoonl merged commit b7db115 into RobotWebTools:develop Dec 7, 2016
@paulashbourne
Copy link

paulashbourne commented Feb 26, 2018

Hi all, any idea when this will be going into a new release?

k-aguete pushed a commit to k-aguete/roslibjs that referenced this pull request Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants