Test more node versions in travis #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the builds are failing |
Rayman
force-pushed
the
test-more-node-versions
branch
from
ab532e3 to
302dbdb
Compare
|
I rebased and it looks like travis still fails but I'm unable to reproduce that issue on my machine. During an other build it looked like issue #114 occured again... https://travis-ci.org/Rayman/roslibjs/builds/80210067. I'll continue looking for a solution. |
Rayman
force-pushed
the
test-more-node-versions
branch
from
302dbdb to
19502fd
Compare
|
I added the dependencies for chai and mocha and now everything works again. |
Make sure to only update npm in the 0.8 and 0.10 versions to not run into this issue: nodejs/node#433
Rayman
force-pushed
the
test-more-node-versions
branch
from
5b7b059 to
2cbd3a4
Compare
|
Rebase to fix a merge conflic in package.json |
rctoris
added a commit
that referenced
this pull request
Oct 9, 2015
Test more node versions in travis
k-aguete
pushed a commit
to k-aguete/roslibjs
that referenced
this pull request
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some more node versions to test for and cleaned the travis script. The current version of node is v4.0.0 and roslib doesn't work on that due to an issue in Automattic/node-canvas#622. We could fix this with #194.
Version 1 and 2 are versions of io.js but apparently roslib works fine on there. Version 3 was the 'alpha' of node v4.