-
Notifications
You must be signed in to change notification settings - Fork 397
update package xml as a prep for npm publish #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"name": "roslibjs", | ||
"main": "./src/RosLibNode.js", | ||
"name": "roslib", | ||
"main": "./build/roslib.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break node, main
is for usage in nodejs and browersify
is for compiling for the browser :)
Ah Since we are releasing roslib.js in build directory which include everything, I thought we should not release src directory in npm. They are duplicated information. Also users should be able to use roslib like the following rather than digging through src directory.
To keep the similar use pattern as browser version introduced in our example It was the reason But I can see your point that it would break browserify process. Could we find a way to release just a built version(in build directory) without exposing If there is no alternate way, yeah we should include |
You only need to include the license and build files (see underscore.js) We use various shims to mock things like browser compliant xml parsers for node. Not exposing the |
Also, in regards to browserify usage of the src directory, exposing src allows people to make slimmer builds excluding things like |
They can do that currently, leaving |
Ah.. maybe I am misunderstanding something. Could we gchat quickly? |
After chatting with @megawac, it becomes clear to release src rather than build. PR will get updated. |
@@ -0,0 +1,8 @@ | |||
src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still has to be removed
👍 Thanks for taking lead on this @jihoonl , you know much more of the node side than I! |
ready to go! merging and releasing. |
update package xml as a prep for npm publish
#127
I was intentionally renaming from roslibjs to roslib because I thought .js extension already implies it is javascript module. Would it be better to publish as
roslibjs
for consistency?