-
Notifications
You must be signed in to change notification settings - Fork 54
[drake_bazel_external] Add documentation for proprietary solvers #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[drake_bazel_external] Add documentation for proprietary solvers #391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@BetsyMcPhail for feature review, please.
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @BetsyMcPhail)
This should do a better job of xref to https://drake.mit.edu/from_source.html#building-with-bazel. Also the flags used here are wrong, see the https://github.com/RobotLocomotion/drake/blob/master/tools/flags/BUILD.bazel linked from that doc for the right spelling. Also the environment variables should be illustrated here, per the docs. |
|
Oops, retracted. Somehow I missed that they already were here. However, note that we want
Ya. The piece that's on the website doc but not in the rcfile here is the pointer to
I am OK with the current PR's scope, now that I read it more carefully. Also remember -- feature review here will need to uncomment these lines and run the |
...and remember that this won't work in CI, since DEE CI is not set up to pull the license files and set up the environment variables. We'll have to verify locally. I can definitely add those comments in as you suggested. |
Closes #108.
This change is