Skip to content

Add reference to drake-jenkins-jobs in Jenkinsfile #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tyler-yankee
Copy link
Collaborator

@tyler-yankee tyler-yankee commented Apr 24, 2025

When we created linux-jammy-unprovisioned-external-examples (see #376), the pipeline for that job was copied directly from this repo's Jenkinsfile. They're not identical (the job uses extra parameters), but they should be operating from the same baseline in most cases. This serves as a reminder to always make corresponding changes.


This change is Reviewable

Copy link
Collaborator Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we're happy with the language, I'll make a corresponding PR on drake-jenkins-jobs with a similar comment.

+@BetsyMcPhail for feature review, please.

Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @BetsyMcPhail)

@tyler-yankee
Copy link
Collaborator Author

The PR can stay for now, but the need for it very well may change pending resolution of RobotLocomotion/drake#22826.

Copy link
Contributor

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @tyler-yankee)

Copy link
Contributor

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

The wording here seems fine, although I agree we should hold off until the we decide what is happening with drake issue.

Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [betsymcphail] (waiting on @tyler-yankee)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants