Fixed format warnings in 64 bit integer builds. #700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were print format warnings when 64-bit integers are enabled. The
fprintf
statements were using "%d" or "%i" as integer conversion specifiers which are the ones for 32-bit integers. 64-bit are "%lld" (MacOS) or "%ld" (Linux):I added the preprocessor defines CBLAS_IFMT and LAPACK_IFMT which use the correct specifier (platform independent via "inttypes.h"). We could also put
#ifdefs
around eachfprintf
statement which is a bit tedious IMHO.Checklist