Time check flag propagation and default value. #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…project. Enable verbose output (will only show in the log files). Bit of formatting.
|
Can we merge this or should I change something? |
Thanks for ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had an issue where we need architecture flags for the Nagfor compiler to run on Apple Silicon. Those flags are defined from the outside build harness via:
-DCMAKE_Fortran_FLAGS="-Wc,-target,arm64-apple-macos11"-DCMAKE_EXE_LINKER_FLAGS="-Wl,-arch,arm64"The problem was that these flags weren't propagated to the time check subproject, resulting in all of the tests failing including
second_NONE.f. That alone wouldn't be a problem if the default value for TIME_FUNC was set correctly, which wasn't the case.I added the flag propagation as well as the correct default value for TIME_FUNC. I also added
-DCMAKE_VERBOSE_MAKEFILE=ONwhich will add a bit more output to the log files. It won't add anything to stdout or stderr.Checklist