-
Notifications
You must be signed in to change notification settings - Fork 466
Create GitHub action to test CMake build system on Windows #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create GitHub action to test CMake build system on Windows #524
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #524 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1908 1908
Lines 186962 186962
=======================================
Misses 186962 186962 ☔ View full report in Codecov by Sentry. |
58ec577
to
a19341b
Compare
I had a Stack Overflow problem in CBLAS:
The last commit tries to increase the queue manually using |
7d97671
to
94487e0
Compare
I haven't had success in the first attempt. I appreciate it if any Windows user can check my test output: https://github.com/weslleyspereira/lapack/actions/runs/691245251 |
69a28f7
to
0b03636
Compare
Hi @hokb and Window users in general, we are looking for some Windows users who can help with this attempt of a PR. @weslleyspereira is trying to get CI to test also on Windows machines. (Currently we do not test on Windows machines as part of CI.) @weslleyspereira is able to get the code to compile, but the code does not pass the test suites. Any idea/contribution would be welcome. @langou |
Hello! I found the problem under Win10 + Choco (CMake 3.22.1/mingw GCC 11.2.0/Makefile)
tests: diff --git a/CBLAS/testing/CMakeLists.txt b/CBLAS/testing/CMakeLists.txt
index 9b8cfaeb1..141d7339c 100644
--- a/CBLAS/testing/CMakeLists.txt
+++ b/CBLAS/testing/CMakeLists.txt
@@ -4,11 +4,13 @@
#######################################################################
macro(add_cblas_test output input target)
- set(TEST_INPUT "${CMAKE_CURRENT_SOURCE_DIR}/${input}")
+ if(NOT "${input}" STREQUAL "")
+ set(TEST_INPUT "${CMAKE_CURRENT_SOURCE_DIR}/${input}")
+ endif()
set(TEST_OUTPUT "${CMAKE_CURRENT_BINARY_DIR}/${output}")
set(testName "${target}")
- if(EXISTS "${TEST_INPUT}")
+ if(DEFINED TEST_INPUT AND EXISTS "${TEST_INPUT}")
add_test(NAME CBLAS-${testName} COMMAND "${CMAKE_COMMAND}"
-DTEST=$<TARGET_FILE:${target}>
-DINPUT=${TEST_INPUT} The problem was that if the input is an empty string, i.e. I do not have any problem with |
0b03636
to
047b66e
Compare
Thanks for the help, @FulgurIgor. However, there still remain a couple of build issues to be solved. |
d731dbb
to
7c7909e
Compare
7c7909e
to
633440e
Compare
af3e5fd
to
7254dc7
Compare
7254dc7
to
f7b6056
Compare
I marked this as ready to review. I think we can merge this workflow for Windows even if we do not run the test suite. At least we will be able to guarantee that LAPACK builds on Windows. Moreover, I couldn't reproduce the test failures in my windows machine, so I don't really know what is happening with the Docker image |
Solves #523.
This PR adds a Github Action with a test for Windows (latest) using the MinGW generator.
Since this new code is not in the master branch, please look at the GitHub CI running here: https://github.com/weslleyspereira/lapack/actions
TODO list: