-
Notifications
You must be signed in to change notification settings - Fork 63
feat: Added support for ADDHASH command #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
Everything looks in order.
Can you please add a test for add_hash and for aggregate
with schema
?
Okay, I'll add the tests for both. |
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 89.58% 90.49% +0.90%
==========================================
Files 12 12
Lines 1402 1462 +60
==========================================
+ Hits 1256 1323 +67
+ Misses 146 139 -7
Continue to review full report at Codecov.
|
Hey @ashtul , |
Added support for ADDHASH command.
Fixed
_with_schema undefined
error occurred on using a cursor as an argument in aggregate function.Added support for deletion of actual document while using
delete_document
function.Added tests for
addhash
andAggregations
.Fixed errors in reducer.py.