Skip to content

feat: Added support for ADDHASH command #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 6, 2020
Merged

feat: Added support for ADDHASH command #69

merged 8 commits into from
Jul 6, 2020

Conversation

dipinarora9
Copy link
Contributor

@dipinarora9 dipinarora9 commented May 29, 2020

  1. Added support for ADDHASH command.

  2. Fixed _with_schema undefined error occurred on using a cursor as an argument in aggregate function.

  3. Added support for deletion of actual document while using delete_document function.

  4. Added tests for addhash and Aggregations.

  5. Fixed errors in reducer.py.

@gkorland gkorland requested a review from MeirShpilraien June 2, 2020 15:45
Copy link
Contributor

@ashtul ashtul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.
Everything looks in order.

Can you please add a test for add_hash and for aggregate with schema?

@dipinarora9
Copy link
Contributor Author

Okay, I'll add the tests for both.

@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

Merging #69 into master will increase coverage by 0.90%.
The diff coverage is 86.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   89.58%   90.49%   +0.90%     
==========================================
  Files          12       12              
  Lines        1402     1462      +60     
==========================================
+ Hits         1256     1323      +67     
+ Misses        146      139       -7     
Impacted Files Coverage Δ
redisearch/client.py 85.33% <66.66%> (+2.88%) ⬆️
redisearch/reducers.py 100.00% <100.00%> (ø)
test/test.py 98.28% <100.00%> (+0.15%) ⬆️
redisearch/aggregation.py 76.04% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c54dd56...9106c12. Read the comment docs.

@dipinarora9
Copy link
Contributor Author

Hey @ashtul ,
I have added the tests for addhash and aggregations.

@gkorland gkorland requested a review from ashtul July 6, 2020 07:20
@ashtul ashtul merged commit f925eac into RediSearch:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants