Skip to content

use six library for isinstance #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 10, 2020
Merged

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Apr 30, 2020

fix #64

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   90.55%   90.55%           
=======================================
  Files          12       12           
  Lines        1493     1493           
=======================================
  Hits         1352     1352           
  Misses        141      141           
Impacted Files Coverage Δ
redisearch/_util.py 85.71% <100.00%> (ø)
redisearch/client.py 86.02% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be43fe8...8b0bbd9. Read the comment docs.

@ashtul
Copy link
Contributor Author

ashtul commented Apr 30, 2020

@quintonparker can you confirm this fixed the issue

@quintonparker
Copy link
Contributor

@ashtul works on my machine ™️

😄

@gkorland gkorland merged commit 4d8590e into master Jul 10, 2020
@gkorland gkorland deleted the six.binary_type-&-six.integer_types branch July 10, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameError: name 'long' is not defined
4 participants